---
title: "Pull requests, branching, git"
description: "Best practices for pull request size, git strategies, and code review workflows including trunk-based vs git flow approaches."
url: "https://www.rubick.com/wiki/process/pull-requests/"
---

[Edit this page on github](https://github.com/jadeforrest/blog/edit/master/src/content/wiki/process/pull-requests.md)

[Wiki](https://www.rubick.com/wiki/) / [Processes & Methodology](https://www.rubick.com/wiki/process/) / Pull requests, branching, git

# 🔀Pull requests, branching, git

Best practices for pull request size, git strategies, and code review workflows including trunk-based vs git flow approaches.

## Maybe don’t do them

-   [PRs considered harmful](https://open.substack.com/pub/a4al6a/p/stop-using-pull-requests)

## Size of PRs

-   [https://google.github.io/eng-practices/review/developer/small-cls.html](https://google.github.io/eng-practices/review/developer/small-cls.html) is a fantastic writeup on making small PRs.

## Git strategies

-   [git flow vs trunk based dev](https://youtu.be/_w6TwnLCFwA?si=R69Y2OuHa5w837PW) Dave Farley, video

## Stack tooling

-   [Sapling](https://sapling-scm.com/docs/introduction/) is a tool based on internal tools at Facebook used to deal with stacking PRs.
-   [Graphite](https://graphite.com/docs/get-started) is a tool for stacked PRs, inspired by tools created at a number of companies.